BC-7082 Add domain error handler #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevenWaysDP
reviewed
Apr 10, 2024
…ietary way of used package.
dyedwiper
reviewed
Apr 15, 2024
dyedwiper
reviewed
Apr 15, 2024
dyedwiper
reviewed
Apr 15, 2024
| import { ErrorLoggable } from '../loggable'; | ||
|
|
||
| @Injectable() | ||
| export class DomainErrorHandler { |
There was a problem hiding this comment.
Ich frage mich, ob es nicht klarer wäre, einfach den ErrorLogger überall verfügbar zu machen. Im Moment würde es ja aufs gleiche hinaus laufen.
Du hattest noch einen möglichen Fall erwähnt, wo man einen Fehler nicht nur loggen will, sondern vielleicht auch noch eine Email verschicken will, so dass im ErrorHandler weitere Funktionalität hinzukommt. Aber das ist ja schon sehr hypothetisch. Außerdem wäre dann die Frage, ob man den Handler überhaupt noch im ErrorFilter wiederverwenden kann.
There was a problem hiding this comment.
Lass uns später dazu sprechen.
bischofmax
approved these changes
Apr 22, 2024
|
bergatco
pushed a commit
that referenced
this pull request
May 6, 2024
To allow passing errors to our domain workflow a domain error handler is outsource from the error pipline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.