Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1833 load media board #4897

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Apr 5, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

apps/server/src/modules/board/board.module.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,30 @@
import { FeatureDisabledLoggableException } from './feature-disabled.loggable-exception';

describe(FeatureDisabledLoggableException.name, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea btw.. Maybe this loggable is something for the software development channel?

config/default.schema.json Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Apr 8, 2024

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 0779c6f into main Apr 8, 2024
55 of 56 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1833-load-media-board branch April 8, 2024 15:34
bergatco pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants