Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6461 refactor tldraw redis logic #4879

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Conversation

wiaderwek
Copy link
Contributor

@wiaderwek wiaderwek commented Mar 27, 2024

Description

QA note:
Change tested your on env:
https://bc-6461-refactor-redis-logic.nbc.dbildungscloud.dev/
Tested tldraw by checking it works, Used 3 accounts teacher ,substitute teacher, student. Tested saving and upload files. Basic functions like copying writing drawing checked. No issues found.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6461

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@wiaderwek wiaderwek self-assigned this Mar 27, 2024
@wiaderwek wiaderwek force-pushed the BC-6461-refactor-redis-logic branch from 0e6449e to c0963f8 Compare March 27, 2024 17:37
Tomasz Wiaderek added 2 commits March 27, 2024 18:43
@wiaderwek wiaderwek force-pushed the BC-6461-refactor-redis-logic branch from f800dbe to 45dd059 Compare March 27, 2024 17:57
@Loki-Afro Loki-Afro changed the title BC-6461 refactor tldraw redis logis BC-6461 refactor tldraw redis logic Mar 28, 2024
Copy link

sonarqubecloud bot commented Apr 2, 2024

@blazejpass blazejpass merged commit 964008e into main Apr 2, 2024
54 of 55 checks passed
@blazejpass blazejpass deleted the BC-6461-refactor-redis-logic branch April 2, 2024 10:41
bergatco pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants