Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1626 ctl data sheet #4717

Merged
merged 80 commits into from
Feb 2, 2024
Merged

N21-1626 ctl data sheet #4717

merged 80 commits into from
Feb 2, 2024

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Jan 25, 2024 •
edited by MarvinOehlerkingCap
Loading

Description

adds backend functionality to create a datasheet pdf for an external tool.

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

IgorCapCoder and others added 30 commits January 18, 2024 16:57
@IgorCapCoder
WIP getDatasheet endpoint
bf8d376
@IgorCapCoder
get datasheetData and mapping
5690f1f
@IgorCapCoder
adjust to clarified requirements
b8ac772
@IgorCapCoder
date format
4ec3119
@IgorCapCoder
refactoring
c741ec4
@IgorCapCoder
refactoring
a22eca2
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1626-ctl-data-sheet' into N2…
f0b8a35 
…1-1626-ctl-data-sheet
@IgorCapCoder
Merge branch 'main' into N21-1626-ctl-data-sheet
85ddd38
@IgorCapCoder
mini temp fix
3d03e03
@IgorCapCoder
make properties a string
f4138f5
@IgorCapCoder
Merge branch 'main' into N21-1626-ctl-data-sheet
e1e7584
@IgorCapCoder
renaming mustacheTemplate specific files
5e74d3f
@MBergCap
add pdfModule
1aa3af7
@MBergCap
add mustache template
8f43af7
@MBergCap
add pdfService
a55af87
@arnegns
N21-1626 make it work
f08b45f
@arnegns
N21-1626 change to not make it global
d473e22
@IgorCapCoder
unit tests and test factory
5046340
@MBergCap
adjust template
5127c1d
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1626-ctl-data-sheet' into N2…
66456e7 
…1-1626-ctl-data-sheet

# Conflicts:
#	apps/server/src/modules/tool/external-tool/service/external-tool.service.ts
#	apps/server/src/modules/tool/external-tool/uc/external-tool.uc.ts
@IgorCapCoder
unit tests and test factory
0db4bb1
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1626-ctl-data-sheet' into N2…
1c70d0c 
…1-1626-ctl-data-sheet
@IgorCapCoder
uc and service unit tests
b97c878
@MBergCap
adjust template
d6c6b9c
@MBergCap
Merge remote-tracking branch 'origin/N21-1626-ctl-data-sheet' into N2…
0b0e4b3 
…1-1626-ctl-data-sheet
@IgorCapCoder
add location to mapper and factories, fix tests, api test
c1ca657
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1626-ctl-data-sheet' into N2…
0afb978 
…1-1626-ctl-data-sheet
@IgorCapCoder
adjust filename and tests
bfd075c
@IgorCapCoder
Merge branch 'main' into N21-1626-ctl-data-sheet
df29b2f
@MBergCap
adjust template and text
19ecd57
This was referenced Jan 31, 2024
Merged
Merged
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Feb 1, 2024
View reviewed changes
apps/server/src/modules/tool/external-tool/controller/api-test/tool.api.spec.ts Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/mapper/external-tool-datasheet.mapper.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/mapper/external-tool-datasheet.mapper.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/mapper/external-tool-datasheet.mapper.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/mapper/external-tool-datasheet.mapper.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/tool/external-tool/uc/external-tool.uc.spec.ts Outdated Show resolved Hide resolved
...rc/shared/testing/factory/domainobject/tool/external-tool-datasheet-template-data.factory.ts Outdated Show resolved Hide resolved
@IgorCapCoder IgorCapCoder dismissed mrikallab’s stale review February 1, 2024 15:03

all requested changes resolved

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) February 2, 2024 10:28
@IgorCapCoder IgorCapCoder disabled auto-merge February 2, 2024 10:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder merged commit c0265f0 into main Feb 2, 2024
47 of 48 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1626-ctl-data-sheet branch February 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

@mrikallab mrikallab mrikallab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IgorCapCoder @mrikallab @MarvinOehlerkingCap @MBergCap @arnegns