Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1630 populate sanis user import #4707

Merged
merged 35 commits into from
Jan 25, 2024
Merged

N21-1630 populate sanis user import #4707

merged 35 commits into from
Jan 25, 2024

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Jan 18, 2024 •
edited
Loading

Description

Adds an endpoint to user-import module for populate import users with data from moin.schule.

Also introduces a infra module for an schulconnex rest client which can be used in different modules

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@arnegns arnegns added the WIP This feature branch is in progress, do not merge into master. label Jan 18, 2024
alweber-cap
alweber-cap requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@alweber-cap alweber-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review, porimarily on the schulconnex client

apps/server/src/infra/schulconnex-client/schulconnex-rest-client.service.ts Outdated Show resolved Hide resolved
apps/server/src/infra/schulconnex-client/index.ts Outdated Show resolved Hide resolved
apps/server/src/infra/schulconnex-client/schulconnex-rest-client.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/server/server.module.ts Outdated Show resolved Hide resolved
@MarvinOehlerkingCap
- add matching of import users
a3ad3fc 
- rename schoolFactory to schoolEntityFactory
@MarvinOehlerkingCap
tests
f57b22f
@arnegns arnegns added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Jan 24, 2024
@arnegns arnegns changed the title N21 1630 fetch sanis user import N21-1630 populate sanis user import Jan 25, 2024
@arnegns arnegns mentioned this pull request Jan 25, 2024
Merged
1 task
alweber-cap
alweber-cap requested changes Jan 25, 2024
View reviewed changes
apps/server/src/modules/provisioning/loggable/group-role-unknown.loggable.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/service/user-import.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/service/user-import.service.ts Show resolved Hide resolved
apps/server/src/modules/user-import/uc/user-import-fetch.uc.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/uc/user-import-fetch.uc.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/service/strategy/schulconnex-fetch-import-users.service.ts Show resolved Hide resolved
apps/server/src/modules/user-import/service/user-import.service.ts Show resolved Hide resolved
apps/server/src/modules/user/service/user.service.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arnegns arnegns enabled auto-merge (squash) January 25, 2024 15:40
@arnegns arnegns merged commit 74cc4d1 into main Jan 25, 2024
49 checks passed
@arnegns arnegns deleted the N21-1630-fetch-sanis-user-import branch January 25, 2024 16:02
bn-pass added a commit that referenced this pull request Jan 25, 2024
@bn-pass
Merge branch 'main' into BC-6352-no-creator-ref-case
4ff9d79 
* main:
  N21-1630 populate sanis user import (#4707)
  BC-6328 fix error loading board (#4711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alweber-cap alweber-cap alweber-cap approved these changes

Assignees
No one assigned
Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnegns @alweber-cap @IgorCapCoder @MarvinOehlerkingCap