Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1624 Make migration wizard compatible with user login migration #4701

Merged
merged 14 commits into from
Jan 26, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 17, 2024

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1624
hpi-schul-cloud/dof_app_deploy#764
hpi-schul-cloud/nuxt-client#3040

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MarvinOehlerkingCap MarvinOehlerkingCap changed the title N21-1624 Add feature flag for migration wizard N21-1624 Make migration wizard compatible with user login migration Jan 24, 2024
MarvinOehlerkingCap and others added 4 commits January 25, 2024 15:49
# Conflicts:
#	apps/server/src/modules/user-import/config/index.ts
#	apps/server/src/modules/user-import/config/user-import-config.ts
#	apps/server/src/modules/user-import/controller/api-test/import-user.api.spec.ts
#	apps/server/src/modules/user-import/controller/import-user.controller.spec.ts
#	apps/server/src/modules/user-import/loggable/index.ts
#	apps/server/src/modules/user-import/uc/user-import.uc.spec.ts
#	apps/server/src/modules/user-import/uc/user-import.uc.ts
#	apps/server/src/modules/user-import/user-import.module.ts
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arnegns arnegns merged commit 61638de into main Jan 26, 2024
46 of 47 checks passed
@arnegns arnegns deleted the N21-1624-migration-wizard branch January 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants