EW-694 Common Cartridge Course Import

apps/server/src/modules/common-cartridge/import/common-cartridge-file-parser.spec.ts

@@ -0,0 +1,61 @@
+import AdmZip from 'adm-zip';
+import { CommonCartridgeFileParser } from './common-cartridge-file-parser';
+
+describe('CommonCartridgeFileParser', () => {
+	describe('constructor', () => {
+		describe('when manifest file is found', () => {
+			const setup = (manifestName: string) => {
+				const archive = new AdmZip();
+
+				archive.addFile(manifestName, Buffer.from('<manifest></manifest>'));
+
+				const file = archive.toBuffer();
+
+				return { file };
+			};
+
+			it('should use imsmanifest.xml as manifest', () => {
+				const { file } = setup('imsmanifest.xml');
+				const parser = new CommonCartridgeFileParser(file);
+
+				expect(parser.manifest).toBeDefined();
+			});
+
+			it('should use manifest.xml as manifest', () => {
+				const { file } = setup('manifest.xml');
+				const parser = new CommonCartridgeFileParser(file);
+
+				expect(parser.manifest).toBeDefined();
+			});
+		});
+
+		describe('when manifest file is not found', () => {
+			const setup = () => {
+				const archive = new AdmZip();
+				const file = archive.toBuffer();
+
+				return { file };
+			};
+
+			it('should throw', () => {
+				const { file } = setup();
+
+				expect(() => new CommonCartridgeFileParser(file)).toThrow('Manifest file not found');
+			});
+		});
+
+		describe('when file is not an archive', () => {
+			const setup = () => {
+				const file = new AdmZip().toBuffer();
+
+				return { file };
+			};
+
+			it('should throw', () => {
+				const { file } = setup();
+
+				expect(() => new CommonCartridgeFileParser(file)).toThrow('Manifest file not found');
+			});
+		});
+	});
+});

apps/server/src/modules/common-cartridge/import/common-cartridge-file-parser.ts

@@ -0,0 +1,28 @@
+import AdmZip from 'adm-zip';
+import { CommonCartridgeManifestParser } from './common-cartridge-manifest-parser';
+import { CommonCartridgeManifestNotFoundException } from './utils/common-cartridge-manifest-not-found.exception';
+
+export class CommonCartridgeFileParser {
+	private readonly manifestParser: CommonCartridgeManifestParser;
+
+	public constructor(file: Buffer) {
+		const archive = new AdmZip(file);
+
+		this.manifestParser = new CommonCartridgeManifestParser(this.getManifestFileAsString(archive));
+	}
+
+	public get manifest(): CommonCartridgeManifestParser {
+		return this.manifestParser;
+	}
+
+	private getManifestFileAsString(archive: AdmZip): string | never {
+		// imsmanifest.xml is the standard name, but manifest.xml is also valid until v1.3
+		const manifest = archive.getEntry('imsmanifest.xml') || archive.getEntry('manifest.xml');
+
+		if (manifest) {
+			return archive.readAsText(manifest);
+		}
+
+		throw new CommonCartridgeManifestNotFoundException();
+	}
+}

apps/server/src/modules/common-cartridge/import/common-cartridge-manifest-parser.spec.ts

@@ -0,0 +1,91 @@
+import AdmZip from 'adm-zip';
+import { readFile } from 'fs/promises';
+import { CommonCartridgeManifestParser } from './common-cartridge-manifest-parser';
+
+describe('CommonCartridgeManifestParser', () => {
+	const setupFile = async (loadFile: boolean) => {
+		if (!loadFile) {
+			const sut = new CommonCartridgeManifestParser('<manifest></manifest>');
+
+			return { sut };
+		}
+
+		const buffer = await readFile('./apps/server/test/assets/common-cartridge/us_history_since_1877.imscc');
+		const archive = new AdmZip(buffer);
+		const sut = new CommonCartridgeManifestParser(archive.readAsText('imsmanifest.xml'));
+
+		return { sut };
+	};
+
+	describe('getSchema', () => {
+		describe('when schema is present', () => {
+			const setup = async () => setupFile(true);
+
+			it('should return the schema', async () => {
+				const { sut } = await setup();
+				const result = sut.getSchema();
+
+				expect(result).toBe('IMS Common Cartridge');
+			});
+		});
+
+		describe('when schema is not present', () => {
+			const setup = async () => setupFile(false);
+
+			it('should return undefined', async () => {
+				const { sut } = await setup();
+				const result = sut.getSchema();
+
+				expect(result).toBeUndefined();
+			});
+		});
+	});
+
+	describe('getVersion', () => {
+		describe('when version is present', () => {
+			const setup = async () => setupFile(true);
+
+			it('should return the version', async () => {
+				const { sut } = await setup();
+				const result = sut.getVersion();
+
+				expect(result).toBe('1.3.0');
+			});
+		});
+
+		describe('when version is not present', () => {
+			const setup = async () => setupFile(false);
+
+			it('should return undefined', async () => {
+				const { sut } = await setup();
+				const result = sut.getVersion();
+
+				expect(result).toBeUndefined();
+			});
+		});
+	});
+
+	describe('getTitle', () => {
+		describe('when title is present', () => {
+			const setup = async () => setupFile(true);
+
+			it('should return the title', async () => {
+				const { sut } = await setup();
+				const result = sut.getTitle();
+
+				expect(result).toBe('201510-AMH-2020-70C-12218-US History Since 1877');
+			});
+		});
+
+		describe('when title is not present', () => {
+			const setup = async () => setupFile(false);
+
+			it('should return null', async () => {
+				const { sut } = await setup();
+				const result = sut.getTitle();
+
+				expect(result).toBeUndefined();
+			});
+		});
+	});
+});

apps/server/src/modules/common-cartridge/import/common-cartridge-manifest-parser.ts

@@ -0,0 +1,27 @@
+import { JSDOM } from 'jsdom';
+
+export class CommonCartridgeManifestParser {
+	private readonly doc: Document;
+
+	public constructor(manifest: string) {
+		this.doc = new JSDOM(manifest, { contentType: 'text/xml' }).window.document;
+	}
+
+	public getSchema(): string | undefined {
+		const result = this.doc.querySelector('manifest > metadata > schema');
+
+		return result?.textContent ?? undefined;
+	}
+
+	public getVersion(): string | undefined {
+		const result = this.doc.querySelector('manifest > metadata > schemaversion');
+
+		return result?.textContent ?? undefined;
+	}
+
+	public getTitle(): string | undefined {
+		const result = this.doc.querySelector('manifest > metadata > lom > general > title > string');
+
+		return result?.textContent ?? undefined;
+	}
+}

apps/server/src/modules/common-cartridge/import/index.ts

@@ -0,0 +1 @@
+export * from './common-cartridge-file-parser';

apps/server/src/modules/common-cartridge/import/jsdom.d.ts

@@ -0,0 +1,11 @@
+// This is a workaround for the missing types for jsdom, because the types are not included in the package itself.
+// This is a declaration file for the JSDOM class, which is used in the CommonCartridgeManifestParser.
+// Currently the JSDOM types are bit buggy and don't work properly with our project setup.
+
+declare module 'jsdom' {
+	class JSDOM {
+		constructor(html: string, options?: Record<string, unknown>);
+
+		window: Window;
+	}
+}

apps/server/src/modules/common-cartridge/import/utils/common-cartridge-manifest-not-found.exception.spec.ts

@@ -0,0 +1,29 @@
+import { CommonCartridgeManifestNotFoundException } from './common-cartridge-manifest-not-found.exception';
+
+describe('CommonCartridgeManifestNotFoundException', () => {
+	describe('getLogMessage', () => {
+		describe('when returning a message', () => {
+			const setup = () => {
+				const sut = new CommonCartridgeManifestNotFoundException();
+
+				return { sut };
+			};
+
+			it('should contain the type', () => {
+				const { sut } = setup();
+
+				const result = sut.getLogMessage();
+
+				expect(result.type).toEqual('WRONG_FILE_FORMAT');
+			});
+
+			it('should contain the stack', () => {
+				const { sut } = setup();
+
+				const result = sut.getLogMessage();
+
+				expect(result.stack).toEqual(sut.stack);
+			});
+		});
+	});
+});

apps/server/src/modules/common-cartridge/import/utils/common-cartridge-manifest-not-found.exception.ts

@@ -0,0 +1,17 @@
+import { BadRequestException } from '@nestjs/common';
+import { ErrorLogMessage, Loggable } from '@src/core/logger';
+
+export class CommonCartridgeManifestNotFoundException extends BadRequestException implements Loggable {
+	constructor() {
+		super('Manifest file not found.');
+	}
+
+	public getLogMessage(): ErrorLogMessage {
+		const message: ErrorLogMessage = {
+			type: 'WRONG_FILE_FORMAT',
+			stack: this.stack,
+		};
+
+		return message;
+	}
+}

apps/server/src/modules/learnroom/controller/api-test/course.api.spec.ts

@@ -5,6 +5,7 @@ import { INestApplication, StreamableFile } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
 import { Permission } from '@shared/domain/interface';
 import { TestApiClient, UserAndAccountTestFactory, cleanupCollections, courseFactory } from '@shared/testing';
+import { readFile } from 'node:fs/promises';
 
 const createStudent = () => {
 	const { studentUser, studentAccount } = UserAndAccountTestFactory.buildStudent({}, [Permission.COURSE_VIEW]);
@@ -51,6 +52,7 @@ describe('Course Controller (API)', () => {
 
 			return { student, course, teacher };
 		};
+
 		it('should find courses as student', async () => {
 			const { student, course } = setup();
 			await em.persistAndFlush([student.account, student.user, course]);
@@ -65,6 +67,7 @@ describe('Course Controller (API)', () => {
 			expect(data[0].startDate).toBe(course.startDate);
 			expect(data[0].untilDate).toBe(course.untilDate);
 		});
+
 		it('should find courses as teacher', async () => {
 			const { teacher, course } = setup();
 			await em.persistAndFlush([teacher.account, teacher.user, course]);
@@ -96,6 +99,7 @@ describe('Course Controller (API)', () => {
 
 			return { course, teacher, teacherUnkownToCourse, substitutionTeacher, student1 };
 		};
+
 		it('should find course export', async () => {
 			const { teacher, course } = setup();
 			await em.persistAndFlush([teacher.account, teacher.user, course]);
@@ -114,4 +118,27 @@ describe('Course Controller (API)', () => {
 			expect(response.header['content-disposition']).toBe('attachment;');
 		});
 	});
+
+	describe('[POST] /courses/import', () => {
+		const setup = async () => {
+			const teacher = createTeacher();
+			const course = await readFile('./apps/server/test/assets/common-cartridge/us_history_since_1877.imscc');
+			const courseFileName = 'us_history_since_1877.imscc';
+
+			await em.persistAndFlush([teacher.account, teacher.user]);
+			em.clear();
+
+			const loggedInClient = await testApiClient.login(teacher.account);
+
+			return { loggedInClient, course, courseFileName };
+		};
+
+		it('should import course', async () => {
+			const { loggedInClient, course, courseFileName } = await setup();
+
+			const response = await loggedInClient.postWithAttachment('import', 'file', course, courseFileName);
+
+			expect(response.statusCode).toEqual(201);
+		});
+	});
 });