Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1655 Fix group timeout #4699

Merged
merged 3 commits into from
Jan 16, 2024
Merged

N21-1655 Fix group timeout #4699

merged 3 commits into from
Jan 16, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 16, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1655

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 72bee55 into main Jan 16, 2024
47 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1655-fix-group-timeout branch January 16, 2024 16:41
virgilchiriac pushed a commit that referenced this pull request Jan 16, 2024
@MarvinOehlerkingCap @virgilchiriac
N21-1655 Fix group timeout (#4699)
aeabe17
virgilchiriac pushed a commit that referenced this pull request Jan 17, 2024
@MarvinOehlerkingCap @virgilchiriac
N21-1655 Fix group timeout (#4699)
e5e262d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns