-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5936 - replace migration library #4680
Conversation
08cfd22
to
cb50bb3
Compare
cb50bb3
to
eadee51
Compare
2abdbc1
to
efe9073
Compare
apps/server/src/mikro-orm.config.ts
Outdated
path: './dist/apps/server/src/migrations/mikro-orm', // path to the folder with migrations | ||
pathTs: './apps/server/src/migrations/mikro-orm', // path to the folder with TS migrations (if used, we should put path to compiled files in `path`) | ||
glob: '!(*.d).{js,ts}', // how to match migration files (all .js and .ts files, but not .d.ts) | ||
transactional: false, // wrap each migration in a transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transations need MongoBD replica - local / dev cluster does not work
perhaps TODO for staging / prod
5e36500
to
140883c
Compare
for console mikroorm config findOneOrFailHandler
f5e982b
to
4668d0d
Compare
This reverts commit d321d68.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@virgilchiriac can you please replace strings in [mikro-orm-cli.config.ts] with my example
const pathToMigrations = resolve(__dirname, '..', 'migrations', 'mikro-orm');
{
...
path: pathToMigrations, // path to the folder with migrations
pathTs: pathToMigrations, // path to the folder with TS migrations (if used, we should put path to compiled files in `path`)
...
}
mikro-orm has a migration bug in windows which is solved only in 5.6.8
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Links to Tickets or other pull requests
BC-5936
hpi-schul-cloud/schulcloud-documentation#20
Changes
npm run setup
- was removed. You should use instead npm run setup:db:seednpm run migration up
was removed. Instead, on local env you should usenpx mikro-orm migration:up
while on CInpm run migration:up
(runs only on the build js files)apps/server/src/migrations/mikro-orm
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.