BC-6131 - fix test factory for school year

[virgilchiriac]

Description

Links to Tickets or other pull requests

BC-6131

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

• DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
• QA: In addition to review, the code has been manually tested (if manual testing is possible)
• All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

[Loki-Afro]

please also improve the test in schoolyear.repo.integration.whatever

create a few school years, make sure the correct one is found

• create a sequence of years
• make sure findCurrentYear() returns the one relevant for the current date

basically the reverse of what you just did

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud