Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6082 Add Logger to KNL-Module #4668

Merged
merged 25 commits into from
Jan 14, 2024
Merged

BC-6082 Add Logger to KNL-Module #4668

merged 25 commits into from
Jan 14, 2024

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Dec 29, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6082

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow added the WIP This feature branch is in progress, do not merge into master. label Dec 29, 2023
@WojciechGrancow WojciechGrancow self-assigned this Dec 29, 2023
@WojciechGrancow WojciechGrancow added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Jan 3, 2024
bn-pass
bn-pass suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@bn-pass bn-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just add some more metadata to the logged events to make them more useful.

apps/server/src/modules/learnroom/service/course.service.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/class/service/class.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/files/service/files.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/files/service/files.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/service/course.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/pseudonym/service/pseudonym.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/registration-pin/service/registration-pin.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/rocketchat-user/service/rocket-chat-user.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/teams/service/team.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user/service/user.service.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WojciechGrancow WojciechGrancow merged commit 3bf7056 into main Jan 14, 2024
46 of 47 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-6082-add-logger-to-KNL-module branch January 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn-pass bn-pass bn-pass approved these changes

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees

@WojciechGrancow WojciechGrancow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WojciechGrancow @SevenWaysDP @bn-pass @sszafGCA