Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5835 Add Task to KNL Deletion module #4667

Merged
merged 28 commits into from
Jan 5, 2024
Merged

BC-5835 Add Task to KNL Deletion module #4667

merged 28 commits into from
Jan 5, 2024

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Dec 27, 2023 •
edited by KacperPassCon
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5835

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow added the WIP This feature branch is in progress, do not merge into master. label Dec 27, 2023
@WojciechGrancow WojciechGrancow self-assigned this Dec 27, 2023
@WojciechGrancow WojciechGrancow added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Dec 28, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WojciechGrancow WojciechGrancow merged commit 6e99df3 into main Jan 5, 2024
45 of 46 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-5835-Add-Task-to-KNLDeletion branch January 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazejpass blazejpass blazejpass approved these changes

@bn-pass bn-pass bn-pass approved these changes

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees

@WojciechGrancow WojciechGrancow

Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WojciechGrancow @SevenWaysDP @bn-pass @blazejpass