Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6111 - default system and federal state #4665

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Dec 22, 2023

Description

Links to Tickets or other pull requests

BC-6111

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud


const tenant = process.env.SC_THEME;
let federalStateName = 'Brandenburg';
if (tenant !== 'n21') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeh, that would be Brandenburg, set above....This is not cleared with PO, but we have only test schools

@virgilchiriac virgilchiriac merged commit 80d8bd5 into main Dec 28, 2023
46 of 47 checks passed
@virgilchiriac virgilchiriac deleted the BC-6111-missing-federal-state branch December 28, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants