BC-5832- Add deleting creator ID reference from the files entities (the legacy files, rewritten from FeathersJS) in the main user deletion use case #4662
Conversation
| for (let i = 0; i < entities.length; i += 1) { | ||
| expect(entities[i].permissions).not.toContain(userPermission); | ||
| if (i === 1 || i === 3) { | ||
| expect(entities[i]._creatorId).toBe(undefined); | ||
| } | ||
| expect(entities[i].permissions).toContain(anotherUserPermission); | ||
| expect(entities[i].permissions).toContain(yetAnotherUserPermission); | ||
| } |
There was a problem hiding this comment.
Why should a test have so much logic?
There was a problem hiding this comment.
this test was already existing I just added to it needed data to cover all posibilities after code modification
There was a problem hiding this comment.
I already understood. But still I was expecting more separate tests than for and if statements in the tests. For me, the for and if statements are things to test again.
|
pls find a short concise summary for this PR (normally 50 characters (details can be added in body according to guidelines) |
Co-authored-by: Sergej Hoffmann <[email protected]>
Co-authored-by: Sergej Hoffmann <[email protected]>
| for (let i = 0; i < entities.length; i += 1) { | ||
| expect(entities[i].permissions).not.toContain(userPermission); | ||
| if (i === 1 || i === 3) { | ||
| expect(entities[i]._creatorId).toBe(undefined); | ||
| } | ||
| expect(entities[i].permissions).toContain(anotherUserPermission); | ||
| expect(entities[i].permissions).toContain(yetAnotherUserPermission); | ||
| } |
There was a problem hiding this comment.
I already understood. But still I was expecting more separate tests than for and if statements in the tests. For me, the for and if statements are things to test again.
|
Description
Added deletion of creator id reference from file entity. Modified service method to wrap it up with other updates to make sure that one file was not counted twice as updated.
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.