Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1587 protected custom parameter #4658

Merged
merged 10 commits into from
Dec 22, 2023
Merged

N21-1587 protected custom parameter #4658

merged 10 commits into from
Dec 22, 2023

Conversation

MBergCap
Copy link
Contributor

@MBergCap MBergCap commented Dec 20, 2023 •
edited
Loading

Description

Extend CTL custom parameter model

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1587
hpi-schul-cloud/superhero-dashboard#241
hpi-schul-cloud/nuxt-client#2968

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MBergCap MBergCap added the WIP This feature branch is in progress, do not merge into master. label Dec 20, 2023
@MBergCap MBergCap mentioned this pull request Dec 20, 2023
Merged
1 task
@IgorCapCoder IgorCapCoder mentioned this pull request Dec 21, 2023
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) December 22, 2023 10:37
@IgorCapCoder IgorCapCoder removed the WIP This feature branch is in progress, do not merge into master. label Dec 22, 2023
@IgorCapCoder IgorCapCoder merged commit a13a017 into main Dec 22, 2023
45 of 46 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1587-protected-custom-parameter branch December 22, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alweber-cap alweber-cap alweber-cap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBergCap @alweber-cap @IgorCapCoder