Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6087 - fix unstable API tests #4657

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

bn-pass
Copy link
Contributor

@bn-pass bn-pass commented Dec 19, 2023

Description

Links to Tickets or other pull requests

BC-6087

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sszafGCA sszafGCA self-requested a review December 19, 2023 16:27
Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really not a fan of that much logic just to write a dump assertion comparing 2 dates

look here for the code https://github.com/assertj/assertj/blob/36658a0bf3ea81f4a2ccc453282f73010e1d7406/assertj-core/src/main/java/org/assertj/core/api/AbstractLocalDateTimeAssert.java#L497

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bn-pass bn-pass merged commit 2a7b5ae into main Dec 19, 2023
45 of 46 checks passed
@bn-pass bn-pass deleted the BC-6087-fix-unstable-unit-test branch December 19, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants