Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6088 devcluster split preparation #4656

Merged
merged 1 commit into from
Dec 19, 2023
Merged

BC-6088 devcluster split preparation #4656

merged 1 commit into from
Dec 19, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 19, 2023

change the call to the namespace activator to an internal one so we don't have the dependency on the domain here

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6088

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

change the call to the namespace activator to an internal one so we
don't have the dependency on the domain here
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Loki-Afro Loki-Afro enabled auto-merge (squash) December 19, 2023 16:28
@Loki-Afro Loki-Afro merged commit a8d50bc into main Dec 19, 2023
45 of 46 checks passed
@Loki-Afro Loki-Afro deleted the bc-6088 branch December 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants