Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5658 update gh-actions remove dof_bingo #4655

Merged
merged 2 commits into from
Dec 19, 2023
Merged

BC-5658 update gh-actions remove dof_bingo #4655

merged 2 commits into from
Dec 19, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 19, 2023

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5658
#4655
hpi-schul-cloud/schulcloud-client#3374
hpi-schul-cloud/h5p-staticfiles-server#8
hpi-schul-cloud/superhero-dashboard#240
hpi-schul-cloud/nuxt-client#2964
hpi-schul-cloud/antivirus_check_service#49
hpi-schul-cloud/version-aggregator#16

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

as the usage changed there to do conflicting uploads
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Loki-Afro Loki-Afro merged commit 70035f6 into main Dec 19, 2023
45 of 46 checks passed
@Loki-Afro Loki-Afro deleted the bc-5658 branch December 19, 2023 13:46
with:
context: .
file: ./Dockerfile
platforms: linux/amd64
pull: true
push: true
pull: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid - pull already defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants