Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6072 fixup h5p unit tests #4651

Merged
merged 2 commits into from
Dec 18, 2023
Merged

BC-6072 fixup h5p unit tests #4651

merged 2 commits into from
Dec 18, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 18, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6072

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac virgilchiriac enabled auto-merge (squash) December 18, 2023 16:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@virgilchiriac virgilchiriac merged commit e1c1edd into main Dec 18, 2023
46 of 47 checks passed
@virgilchiriac virgilchiriac deleted the bc-6072 branch December 18, 2023 16:28
virgilchiriac pushed a commit that referenced this pull request Dec 18, 2023
@Loki-Afro @virgilchiriac
BC-6072 - fix h5p unit tests (#4651)
6c61e63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loki-Afro @virgilchiriac