BC-5942 - dedicated ConfigMap and Secret for the Admin API deployment #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechGrancow
approved these changes
Dec 15, 2023
SevenWaysDP
approved these changes
Dec 15, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-5942
Changes
This ticket separate the Admin API deployment's ConfigMap and Secret definitions to a separate k8s manifest files.
Datasecurity
Deployment
New k8s ConfigMap and Secret objects has been added.
New Repos, NPM packages or vendor scripts
No new packages or any other in-code dependencies.
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.