-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-6040 - Redis Packages Update for Server and legacy client #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergatco
added
the
WIP
This feature branch is in progress, do not merge into master.
label
Dec 15, 2023
- due to `cache-manager-redis-store` seemingly no longer being maintaned, it needed to be replaced by `cache-manager-redis-yet` - also removed unneeded packages (`types/cache-manager-redis-store` and `@types/connect-redis`) - some code changes to accomodate the new packages
Merged
3 tasks
…cloud/schulcloud-server into BC-6040-update-redis-packages
bergatco
commented
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything a-okay from my side! 👍
dyedwiper
approved these changes
Jan 9, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
dyedwiper
removed
the
WIP
This feature branch is in progress, do not merge into master.
label
Jan 10, 2024
virgilchiriac
added a commit
that referenced
this pull request
Jan 19, 2024
dyedwiper
added a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To get the Redis cluster to work the redis packages from the server and legacy client must be update to Version 4.x.x
Your task is to update the redis and corresponding package from server and legacy client to the latest possible version.
The Redis package must be minimum at Version 4.x.x
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-6040
hpi-schul-cloud/schulcloud-client#3371
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.