Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6040 - Redis Packages Update for Server and legacy client #4641

Merged
merged 14 commits into from
Jan 10, 2024

Conversation

bergatco
Copy link
Contributor

@bergatco bergatco commented Dec 15, 2023

Description

To get the Redis cluster to work the redis packages from the server and legacy client must be update to Version 4.x.x
Your task is to update the redis and corresponding package from server and legacy client to the latest possible version.
The Redis package must be minimum at Version 4.x.x

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6040
hpi-schul-cloud/schulcloud-client#3371

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bergatco bergatco added the WIP This feature branch is in progress, do not merge into master. label Dec 15, 2023
@bergatco bergatco self-assigned this Dec 15, 2023
- due to `cache-manager-redis-store` seemingly no longer being maintaned, it needed to be replaced by `cache-manager-redis-yet`
- also removed unneeded packages (`types/cache-manager-redis-store` and `@types/connect-redis`)
- some code changes to accomodate the new packages
@dyedwiper dyedwiper assigned dyedwiper and bergatco and unassigned bergatco and dyedwiper Jan 9, 2024
Copy link
Contributor Author

@bergatco bergatco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything a-okay from my side! 👍

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyedwiper dyedwiper removed the WIP This feature branch is in progress, do not merge into master. label Jan 10, 2024
@dyedwiper dyedwiper merged commit 272bffe into main Jan 10, 2024
46 of 47 checks passed
@dyedwiper dyedwiper deleted the BC-6040-update-redis-packages branch January 10, 2024 09:49
dyedwiper added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants