-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5834-Add-Dashboard-Entities-Deletion-to-the-Main-User-Deletion-Use-Case #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechGrancow
added
the
WIP
This feature branch is in progress, do not merge into master.
label
Dec 7, 2023
WojciechGrancow
added
waiting for review
and removed
WIP
This feature branch is in progress, do not merge into master.
labels
Dec 12, 2023
bn-pass
suggested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small unused import to be removed, other than that looks good to me.
apps/server/src/modules/learnroom/service/dashboard.service.spec.ts
Outdated
Show resolved
Hide resolved
…ec.ts Co-authored-by: Bartosz Nowicki <[email protected]>
bn-pass
approved these changes
Dec 12, 2023
SevenWaysDP
requested changes
Dec 14, 2023
Co-authored-by: Sergej Hoffmann <[email protected]>
Co-authored-by: Sergej Hoffmann <[email protected]>
…b.com/hpi-schul-cloud/schulcloud-server into BC-58340-Add-Dashboard-to-KNLDeletion
SevenWaysDP
approved these changes
Dec 15, 2023
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-5834
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.