Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-4209 improve logging to identify teachers without firstnames in tsp #4616

Merged
merged 3 commits into from
Dec 6, 2023
Merged

BC-4209 improve logging to identify teachers without firstnames in tsp #4616

merged 3 commits into from
Dec 6, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 5, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4209

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Loki-Afro Loki-Afro enabled auto-merge (squash) December 5, 2023 16:24
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Loki-Afro Loki-Afro merged commit 1df15ec into main Dec 6, 2023
48 checks passed
@Loki-Afro Loki-Afro deleted the bc-4209 branch December 6, 2023 08:59
bergatco pushed a commit that referenced this pull request Dec 6, 2023
@Loki-Afro @bergatco
BC-4209 improve logging to identify teachers without firstnames in tsp (
db9bc8b 
#4616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loki-Afro @MartinSchuhmacher