New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1483 replace oauth sso error #4605

Merged

arnegns merged 10 commits into main from N21-1483-oauth-error-to-loggable

Dec 4, 2023

Contributor

arnegns commented Dec 1, 2023 •

edited by MarvinOehlerkingCap

Loading

Description

Replaces oauth sso error with some loggables

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1483

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
QA: In addition to review, the code has been manually tested (if manual testing is possible)
All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

arnegns added 7 commits

December 1, 2023 11:28


          N21-1483 removes oauth sso error

8cef284


          N21-1483 fixes test

6e6627e


          N21-1483 fixes test

cbf9464


          N21-1483 fixes test 2

45376bb


          N21-1483 adds loggable unit tests

c239802


          N21-1483 fixes test

7d058bb


          Merge branch 'main' into N21-1483-oauth-error-to-loggable

MarvinOehlerkingCap approved these changes

View reviewed changes

Contributor

MarvinOehlerkingCap left a comment

just some minor changes required

apps/server/src/modules/oauth/loggable/id-token-invalid-loggable-exception.spec.ts Show resolved Hide resolved

apps/server/src/modules/oauth/loggable/id-token-user-not-found-loggable-exception.spec.ts Show resolved Hide resolved

apps/server/src/modules/oauth/loggable/oauth-config-missing-loggable-exception.ts Outdated Show resolved Hide resolved

apps/server/src/modules/oauth/loggable/oauth-config-missing-loggable-exception.spec.ts Outdated Show resolved Hide resolved

apps/server/src/modules/provisioning/strategy/iserv/iserv.strategy.ts Outdated Show resolved Hide resolved

arnegns added 3 commits

December 4, 2023 07:03


          Merge branch 'main' into N21-1483-oauth-error-to-loggable

9c7c3ed


          N21-1483 review changes

5d52943


          N21-1483 revert loggable exports

a1189ca

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

arnegns enabled auto-merge (squash)

December 4, 2023 07:56

arnegns merged commit 3164f26 into main

47 of 48 checks passed

arnegns deleted the N21-1483-oauth-error-to-loggable branch

December 4, 2023 08:46

bergatco pushed a commit that referenced this pull request


          N21-1483 replace oauth sso error (#4605)

abbadc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet