EW-539 adding Learnstore links to the Common Cartridge export #4599
Conversation
Co-authored-by: Patrick Sachmann <[email protected]>
| @@ -4,7 +4,7 @@ import { | |||
| createCommonCartridgeOrganizationElementPropsV110, | |||
| createCommonCartridgeOrganizationsWrapperElementPropsV110, | |||
| createCommonCartridgeResourcesWrapperElementPropsV110, | |||
| } from '@shared/testing/factory/common-cartridge-element-props.factory'; | |||
| } from '@src/modules/common-cartridge/testing/common-cartridge-element-props.factory'; | |||
There was a problem hiding this comment.
Please use relativer path inside the same module ../../../testing/common-cartridge-element-props.factory
For all other places too.
| import { Test, TestingModule } from '@nestjs/testing'; | ||
| import { ComponentProperties, ComponentType } from '@shared/domain/entity'; | ||
| import { courseFactory, lessonFactory, setupEntities, taskFactory, userFactory } from '@shared/testing'; | ||
| import { OmitVersion, createIdentifier } from '@src/modules/common-cartridge/export/utils'; |
There was a problem hiding this comment.
from '@modules/common-cartridge';
| import { Injectable } from '@nestjs/common'; | ||
| import { ConfigService } from '@nestjs/config'; | ||
| import { ComponentProperties, ComponentType, Course, LessonEntity, Task } from '@shared/domain/entity'; | ||
| import { createIdentifier } from '@src/modules/common-cartridge/export/utils'; |
There was a problem hiding this comment.
from '@modules/common-cartridge';
|
|
||
| @Module({ | ||
| imports: [ | ||
| BoardModule, | ||
| forwardRef(() => BoardModule), |
There was a problem hiding this comment.
You add it to avoid dependency cycles? If yes, then please note that you remove it in the account module refactoring.
There was a problem hiding this comment.
Are you sure if this will be the case? We can try, but i think those cycles are seated deeper in general
| import { ToolVersionService } from './service/tool-version-service'; | ||
|
|
||
| @Module({ | ||
| imports: [CommonToolModule, ExternalToolModule, SchoolExternalToolModule, LoggerModule, ToolConfigModule], | ||
| imports: [ | ||
| forwardRef(() => CommonToolModule), |
There was a problem hiding this comment.
Same forwardRef`s must be removed, later i expect with the change in account module.
| import { CommonToolModule } from '../common'; | ||
| import { ExternalToolModule } from '../external-tool'; | ||
| import { ToolConfigModule } from '../tool-config.module'; | ||
| import { SchoolExternalToolService, SchoolExternalToolValidationService } from './service'; | ||
|
|
||
| @Module({ | ||
| imports: [CommonToolModule, ExternalToolModule, ToolConfigModule], | ||
| imports: [forwardRef(() => CommonToolModule), forwardRef(() => ExternalToolModule), ToolConfigModule], |
There was a problem hiding this comment.
Remove with account module change.
|
Description
Expending the common cartridge export with the with Learnstore links and refactoring the common cartridge module for easier extension and integration with other resource types.
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.