Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5119-Prevent created nexboard in copy course process #4581

Closed
wants to merge 5 commits into from
Closed

BC-5119-Prevent created nexboard in copy course process #4581

wants to merge 5 commits into from

Conversation

Michaellinaresxk
Copy link
Contributor

@Michaellinaresxk Michaellinaresxk commented Nov 27, 2023 •
edited
Loading

Description

Prevent copy Nexboard on copy course process.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5119

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac
Copy link
Contributor

the unit test (possibly also api tests) must cover all changes

@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards-server branch 4 times, most recently from c53849d to e1ae182 Compare November 30, 2023 08:42
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards-server branch from 8dac329 to 78f7baf Compare December 4, 2023 11:27
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards-server branch from f08db91 to ec827c8 Compare December 4, 2023 12:15
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards-server branch from 76b0c05 to ef80271 Compare December 4, 2023 14:38
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards-server branch from a5429b6 to 17c39c3 Compare December 5, 2023 12:03
@davwas
Copy link
Contributor

davwas commented Dec 8, 2023

Closing this pull request as I will be reopening my own.

@davwas davwas closed this Dec 8, 2023
@davwas davwas deleted the BC-5119-Prevent-creating-new-neXboards-server branch December 8, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michaellinaresxk @virgilchiriac @davwas