BC-5119-Prevent-creating-new-neXboard #4571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaellinaresxk
force-pushed
the
BC-5119-Prevent-creating-new-neXboards-server
branch
from
8fe990d to
5af96f7
Compare
Michaellinaresxk
changed the title
virgilchiriac
requested changes
Nov 24, 2023
|
|
||
| return courseStatus; | ||
| } | ||
|
|
||
| // Exclude LESSON_CONTENT_NEXBOARD from boardStatus | ||
| private filterOutNeXboardFromCopyStatus(boardStatus: CopyStatus): CopyStatus { |
There was a problem hiding this comment.
why not using here the feature flag too?
| if (element.component === ComponentType.NEXBOARD && nexboardEnabled) { | ||
| // eslint-disable-next-line no-await-in-loop | ||
|
|
||
| if (element.component === ComponentType.NEXBOARD && nexboardEnabled && copyNexboardEnabled) { |
There was a problem hiding this comment.
so, if copy feature flag is false, nothing is returned.
if copy is true, a NOT_DOING status is returned.
this is not how it should work...
if copy flag is false, then it should return status NOT_DOING
if it is true, it should remain as it is...
Michaellinaresxk
force-pushed
the
BC-5119-Prevent-creating-new-neXboards-server
branch
from
2fbf84a to
654f926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.