Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5831-rewriting-regpin-deletion #4570

Merged
merged 19 commits into from
Nov 28, 2023
Merged

BC-5831-rewriting-regpin-deletion #4570

merged 19 commits into from
Nov 28, 2023

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Nov 22, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5831

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow added the WIP This feature branch is in progress, do not merge into master. label Nov 22, 2023
@WojciechGrancow WojciechGrancow self-assigned this Nov 22, 2023
@WojciechGrancow WojciechGrancow added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Nov 24, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@WojciechGrancow WojciechGrancow merged commit fd8dd82 into main Nov 28, 2023
48 of 49 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-5831-rewriting-regpin-deletion branch November 28, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

@wiaderwek wiaderwek wiaderwek approved these changes

Assignees

@WojciechGrancow WojciechGrancow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WojciechGrancow @wiaderwek @SevenWaysDP