Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1488 Fix optional external tool parameter with regex #4558

Merged
merged 2 commits into from
Nov 15, 2023
Merged

N21-1488 Fix optional external tool parameter with regex #4558

merged 2 commits into from
Nov 15, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 15, 2023 •
edited by arnegns
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1488
hpi-schul-cloud/nuxt-client#2914

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Nov 15, 2023
Merged
3 tasks
@arnegns arnegns self-requested a review November 15, 2023 12:10
@MarvinOehlerkingCap MarvinOehlerkingCap enabled auto-merge (squash) November 15, 2023 15:07
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 8f1aea3 into main Nov 15, 2023
45 of 46 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1488-fix-optional-regex-again branch November 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns