BC-5628 cyclic data deletion

[bn-pass]

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5628

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

• DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
• QA: In addition to review, the code has been manually tested (if manual testing is possible)
• All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

[mamutmk5]

Why do not the deletion cronjob execute the deletion and why do it call the api?
Form me it's look like the code base has all what you need to delete the data at database and so on.
From my view the cyclic data deletion cron job should work without an server api call and execute the delition self, it's more secure.

[bn-pass]

Why do not the deletion cronjob execute the deletion and why do it call the api? Form me it's look like the code base has all what you need to delete the data at database and so on. From my view the cyclic data deletion cron job should work without an server api call and execute the delition self, it's more secure.

@mamutmk5 It shouldn't be like that as it's an anti-pattern: this way the CronJob would get a "side access" to the main schulcloud-server's database. According to the best standards only the schulcloud-server should have access to its own database, no other apps/jobs should have a direct access and manipulate the main schulcloud-server database's data. That's why we've only put the trigger to delete the data in the CronJob, but the main operation execution remains in the schulcloud-server's deployment responsibility (which is exposed through the Admin API).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication