Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1374 removes old login flow #4541

Merged
merged 10 commits into from
Nov 13, 2023
Merged

N21-1374 removes old login flow #4541

merged 10 commits into from
Nov 13, 2023

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Nov 9, 2023 •
edited
Loading

Description

Removes the old login which handled the oauth login on server side.

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@arnegns arnegns added the WIP This feature branch is in progress, do not merge into master. label Nov 9, 2023
This was referenced Nov 9, 2023
Merged
Merged
@arnegns arnegns mentioned this pull request Nov 10, 2023
Merged
3 tasks
@arnegns arnegns removed the WIP This feature branch is in progress, do not merge into master. label Nov 10, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 13, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@arnegns arnegns merged commit b11b022 into main Nov 13, 2023
46 of 47 checks passed
@arnegns arnegns deleted the N21-1374-remove-old-login-flow branch November 13, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnegns @MarvinOehlerkingCap