N21-1398 hide mail section for ldap #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinOehlerkingCap
requested changes
Nov 8, 2023
There was a problem hiding this comment.
I don't like the introduction of a marker interface for ldap, since marker interfaces are used to provide runtime information and types don't exist at runtime. It also does not provide any benefit in readability or logic while programming, since the objects and their uses are identical, imo.
apps/server/src/modules/authentication/interface/ldap-current-user.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/authentication/mapper/current-user.mapper.ts
Outdated
Show resolved
Hide resolved
MarvinOehlerkingCap
approved these changes
Nov 8, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ldap to external system for skipping email section on first login
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1398
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.