Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5655 move shared infra #4526

Merged
merged 9 commits into from
Nov 8, 2023
Merged

BC-5655 move shared infra #4526

merged 9 commits into from
Nov 8, 2023

Conversation

CeEv
Copy link
Contributor

@CeEv CeEv commented Nov 7, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@CeEv CeEv requested a review from SevenWaysDP November 7, 2023 14:11
@CeEv CeEv enabled auto-merge (squash) November 8, 2023 08:23
SevenWaysDP
SevenWaysDP approved these changes Nov 8, 2023
View reviewed changes
apps/server/src/console/api-test/database-management.console.api.spec.ts Show resolved Hide resolved
apps/server/src/infra/calendar/mapper/calendar.mapper.ts Outdated Show resolved Hide resolved
apps/server/src/infra/calendar/service/calendar.service.spec.ts Outdated Show resolved Hide resolved
apps/server/src/infra/calendar/service/calendar.service.ts Outdated Show resolved Hide resolved
apps/server/src/infra/collaborative-storage/collaborative-storage-adapter.module.ts Outdated Show resolved Hide resolved
apps/server/src/modules/collaborative-storage/collaborative-storage.module.ts Outdated Show resolved Hide resolved
apps/server/src/modules/files-storage/files-storage-test.module.ts Outdated Show resolved Hide resolved
apps/server/src/modules/files-storage/files-storage.module.ts Outdated Show resolved Hide resolved
apps/server/src/modules/lesson/service/etherpad.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/lesson/service/nexboard.service.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@CeEv CeEv merged commit 3cf0fd5 into main Nov 8, 2023
45 of 46 checks passed
@CeEv CeEv deleted the BC-5655-move-shared-infra branch November 8, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CeEv @SevenWaysDP