Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5705 - Remove fwu ingress #4515

Merged
merged 3 commits into from
Nov 2, 2023
Merged

BC-5705 - Remove fwu ingress #4515

merged 3 commits into from
Nov 2, 2023

Conversation

mamutmk5
Copy link
Member

@mamutmk5 mamutmk5 commented Nov 2, 2023

Description

The extractoion of the FWU Ingress to an own file create issues as the ingress definition where applied so the ingress definitin move back to his old place.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5705
hpi-schul-cloud/dof_app_deploy#688

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@mamutmk5 mamutmk5 requested review from Loki-Afro and bn-pass November 2, 2023 14:33
@mamutmk5 mamutmk5 self-assigned this Nov 2, 2023
@mamutmk5 mamutmk5 marked this pull request as ready for review November 2, 2023 14:33
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mamutmk5 mamutmk5 merged commit 46788a4 into main Nov 2, 2023
46 checks passed
@mamutmk5 mamutmk5 deleted the BC-5705-fwu-fix branch November 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants