Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ew 619 dp review testing part #4492

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
01b8681
review comments 14-07-23
Metauriel Jul 14, 2023
40fb0c0
Delete auto generated test file.
mkreuzkam-cap Sep 14, 2023
8db2af2
Use setup method and account factory in account entity to dto mapper …
mkreuzkam-cap Sep 14, 2023
2a33de2
Use setup method and factories in account response mapper test.
mkreuzkam-cap Sep 14, 2023
c7d00f1
Use setup method and test structure in account idm to dto mapper tests.
mkreuzkam-cap Sep 15, 2023
8234ea3
Use setup method and better test structure in account repo integratio…
mkreuzkam-cap Sep 15, 2023
4208bc2
Use setup and new test structure in account api test (part 1).
mkreuzkam-cap Sep 18, 2023
9e2126c
Use setup and new test structure in account api test (part 2).
mkreuzkam-cap Sep 19, 2023
836b97c
Add missing description for test case.
mkreuzkam-cap Sep 19, 2023
f9ea21e
update function and solve todo
MajedAlaitwniCap Sep 21, 2023
31da828
Use setup and new test structure in account db service test
MajedAlaitwniCap Sep 21, 2023
a958007
new test structure account idm service integration test
MajedAlaitwniCap Sep 22, 2023
edd618d
use setup for account idm service integration test
MajedAlaitwniCap Sep 25, 2023
0575f0b
Use setup and new test structure in account.uc.spec.ts.
mkreuzkam-cap Sep 25, 2023
75fd0cc
use setup for account idm service test
MajedAlaitwniCap Sep 25, 2023
c1bd6ca
Use setup method and new test structure for account.validation.servic…
mkreuzkam-cap Sep 26, 2023
b7b259a
use setup and new test structure for account service integration test
MajedAlaitwniCap Sep 26, 2023
30faf5b
Merge branch 'EW-619-DP-review-testing-part' of https://github.com/hp…
MajedAlaitwniCap Sep 26, 2023
61c3d49
Merge branch 'main' into EW-619-DP-review-testing-part
MajedAlaitwniCap Sep 26, 2023
870477f
Use setup method and new test structure in account.service.spec.ts test.
mkreuzkam-cap Sep 26, 2023
e2e2eb3
Fix order in account.service.integration.spec.ts
mkreuzkam-cap Sep 27, 2023
0f2bbe0
Remove unnecessary tests and resolved todos.
mkreuzkam-cap Sep 27, 2023
64a875f
resolve security hotspot issue
MajedAlaitwniCap Sep 27, 2023
d727557
resolve security hotspot issue
MajedAlaitwniCap Sep 27, 2023
7a72638
Merge branch 'main' into EW-619-DP-review-testing-part
Fshmit Sep 28, 2023
1b762d9
Merge branch 'main' into EW-619-DP-review-testing-part
Fshmit Oct 4, 2023
b4a2e50
Edit describe massages
MajedAlaitwniCap Oct 5, 2023
e62de75
Edit describe massages part 2
MajedAlaitwniCap Oct 6, 2023
01de770
Merge branch 'main' into EW-619-DP-review-testing-part
Fshmit Oct 6, 2023
b2c4c68
Merge branch 'main' into EW-619-DP-review-testing-part
WahlMartin Oct 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Body, Controller, Delete, Get, Param, Patch, Query } from '@nestjs/common';
import { ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger';
import { Authenticate, CurrentUser } from '@src/modules/authentication/decorator/auth.decorator';
import { EntityNotFoundError, ForbiddenOperationError, ValidationError } from '@shared/common';
import { ICurrentUser } from '@src/modules/authentication';
import { Authenticate, CurrentUser } from '@src/modules/authentication/decorator/auth.decorator';
import { AccountUc } from '../uc/account.uc';
import {
AccountByIdBodyParams,
Expand Down Expand Up @@ -33,6 +33,8 @@ export class AccountController {
@Query() query: AccountSearchQueryParams
): Promise<AccountSearchListResponse> {
return this.accountUc.searchAccounts(currentUser, query);

// TODO: mapping from domain to api dto should be a responsability of the controller (also every other function here)
}

@Get(':id')
Expand Down
Loading
Loading