Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5521 - Implement of KNL Control Module #4486

Merged
merged 19 commits into from
Nov 7, 2023

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Oct 19, 2023

Description

This is the core module for the KNL implementation. Version with limited functionality under KNL MVP.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5521

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow added the WIP This feature branch is in progress, do not merge into master. label Oct 19, 2023
@WojciechGrancow WojciechGrancow removed the WIP This feature branch is in progress, do not merge into master. label Nov 1, 2023
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@WojciechGrancow WojciechGrancow merged commit 01065dc into main Nov 7, 2023
46 of 47 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-5521-implementation-KNL-Module branch November 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants