Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5159 - Display error with animated GIFs in the course board #4482

Closed
wants to merge 10 commits into from

Conversation

bergatco
Copy link
Contributor

@bergatco bergatco commented Oct 18, 2023

Description

load various GIF files to the course board. Display errors with different sizes.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5159

Linkt to deployment : https://default-bc-5159-gif-display-error.cd.dbildungscloud.dev/

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bergatco bergatco added the WIP This feature branch is in progress, do not merge into master. label Oct 18, 2023
@bergatco bergatco self-assigned this Oct 18, 2023
@bergatco bergatco requested a review from Loki-Afro October 26, 2023 12:20
SevenWaysDP and others added 5 commits November 2, 2023 14:42
updated-dependencies:
- dependency-name: crypto-js (from 4.1.1 to 4.2.0.)
- dependency-type: direct:production
Separate the Server Ingress to the Server Repo and for each service in an own one.
Add the new ingress definitons files to the ansible roles.
With the current version of nginx ingress is it possible to have more igresses with different resources for one domain.
@bergatco bergatco added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Nov 2, 2023
@bergatco bergatco requested a review from SevenWaysDP November 2, 2023 13:49
@bergatco
Copy link
Contributor Author

bergatco commented Nov 2, 2023

Would like to merge the changes as a "temporary solution" until our ticket with Alpine Linux is completed.

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SevenWaysDP SevenWaysDP deleted the BC-5159-gif-display-error branch November 17, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants