BC-5566 - fix merlin feathers service #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feathers sometimes does not resolves sub-routes correctly. Sub-routes need to be loaded before the main route.
|
no unit tests? |
This reverts commit 3b7860c.
Rename the merlinToken feathers service path to a unique path instead of subpath of edu-shraring Not clear why, but feathers service was suddenly mapped wrong and calling edu-sharing service instead of merlinToken service. Changing the order of the services load helped, but then lots of tests fail. fix player path fix fix fix
This was referenced Oct 18, 2023
MartinSchuhmacher
approved these changes
Oct 18, 2023
it has already some unit tests and the service path was adjusted there accordingly |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feathers sometimes does not resolves sub-routes correctly.
In this case, it was better to have a distict route
instead of edu-sharing/merlinToken use edu-sharing-merlinToken
Description
Links to Tickets or other pull requests
BC-5566
hpi-schul-cloud/nuxt-client#2870
hpi-schul-cloud/dof_app_deploy#673
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.