-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-4983 - submission item children #4452
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgilchiriac
added
WIP
This feature branch is in progress, do not merge into master.
do-not-merge
labels
Oct 4, 2023
virgilchiriac
commented
Oct 13, 2023
@Param() urlParams: SubmissionItemUrlParams, | ||
@Body() bodyParams: CreateContentElementBodyParams, | ||
@CurrentUser() currentUser: ICurrentUser | ||
): Promise<AnyContentElementResponse> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be not any content element response
virgilchiriac
commented
Oct 13, 2023
apps/server/src/modules/board/controller/dto/submission-item/submission-item.response.ts
Show resolved
Hide resolved
virgilchiriac
force-pushed
the
BC-4983-submission-item-children
branch
from
October 16, 2023 07:50
89555a8
to
dbf2267
Compare
3 tasks
virgilchiriac
commented
Oct 16, 2023
| ExternalToolElement | ||
| LinkElementNode; | ||
|
||
export type AnyBoardNode = ColumnBoardNode | ColumnNode | CardNode | AnyElementNode | SubmissionItemNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used - should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-4983
hpi-schul-cloud/nuxt-client#2842
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.