Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4983 - submission item children #4452

Closed
wants to merge 7 commits into from

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Oct 4, 2023

Description

Links to Tickets or other pull requests

BC-4983
hpi-schul-cloud/nuxt-client#2842

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac virgilchiriac added WIP This feature branch is in progress, do not merge into master. do-not-merge labels Oct 4, 2023
@virgilchiriac virgilchiriac self-assigned this Oct 4, 2023
@Param() urlParams: SubmissionItemUrlParams,
@Body() bodyParams: CreateContentElementBodyParams,
@CurrentUser() currentUser: ICurrentUser
): Promise<AnyContentElementResponse> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be not any content element response

| ExternalToolElement
| LinkElementNode;

export type AnyBoardNode = ColumnBoardNode | ColumnNode | CardNode | AnyElementNode | SubmissionItemNode;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used - should be removed

@virgilchiriac virgilchiriac deleted the BC-4983-submission-item-children branch October 18, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant