Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5102 - use type guards #4450

Merged
merged 3 commits into from
Oct 2, 2023
Merged

BC-5102 - use type guards #4450

merged 3 commits into from
Oct 2, 2023

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Oct 2, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac virgilchiriac force-pushed the BC-5102-load-submissions branch from 00e7993 to dde0a23 Compare October 2, 2023 10:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

hoeppner-dataport
hoeppner-dataport approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Only one minor wording suggestion: "Id is not submission container" => "Id does not belong to a submission container".

@virgilchiriac virgilchiriac merged commit 13f4d7a into main Oct 2, 2023
43 checks passed
@virgilchiriac virgilchiriac deleted the BC-5102-load-submissions branch October 2, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoeppner-dataport hoeppner-dataport hoeppner-dataport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgilchiriac @hoeppner-dataport