N21-1324-migration-page-buttons-fix #4447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnegns
suggested changes
Oct 9, 2023
apps/server/src/modules/oauth/controller/api-test/oauth-sso.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/oauth/controller/api-test/oauth-sso.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/oauth/controller/oauth-sso.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/user-login-migration/service/migration-check.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/user-login-migration/service/migration-check.service.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| [] | |||
|
Kudos, SonarCloud Quality Gate passed!
|
arnegns
approved these changes
Oct 9, 2023
| @@ -3,6 +3,7 @@ import { EntityId, LegacySchoolDo, UserDO, UserLoginMigrationDO } from '@shared/ | |||
| import { UserLoginMigrationRepo } from '@shared/repo'; | |||
| import { LegacySchoolService } from '@src/modules/legacy-school'; | |||
| import { UserService } from '@src/modules/user'; | |||
| import { SchoolInMigrationError } from '@src/modules/authentication/errors/school-in-migration.error'; | |||
There was a problem hiding this comment.
Do you really need the whole import?
Until errors should be enough when the error itself will be exported in the barrel file
|
Closed because it is not necessary anylonger since we use the new login flow also for oauth2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the refactoring for adaption of userLoginMigration entity the migration page was shown wrongly in login flow. This Bug fix will show the right error message, when migration is enabled and login via moin.schule is triggered with unknown user in svs.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1324
hpi-schul-cloud/schulcloud-client#3318
hpi-schul-cloud/nuxt-client#2834
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.