N21 1309 fix empty class sync #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorCapCoder
added
the
WIP
IgorCapCoder
removed
the
WIP
IgorCapCoder
commented
Sep 28, 2023
IgorCapCoder
commented
Sep 28, 2023
test/services/sync/strategies/consumerActions/ClassAction.test.js
Outdated
Show resolved
Hide resolved
IgorCapCoder
added
the
WIP
Loki-Afro
previously requested changes
Oct 4, 2023
IgorCapCoder
removed
the
WIP
|
Kudos, SonarCloud Quality Gate passed!
|
arnegns
approved these changes
Oct 5, 2023
| @@ -90,14 +90,16 @@ class ClassAction extends BaseConsumerAction { | |||
| const teachers = []; | |||
| const ldapDns = !Array.isArray(uniqueMembers) ? [uniqueMembers] : uniqueMembers; | |||
|
|
|||
| const users = await UserRepo.findByLdapDnsAndSchool(ldapDns, schoolId); | |||
| if (ldapDns[0]) { | |||
There was a problem hiding this comment.
I think it should return here in case condition is not a valid DN to skip execute the extra update class with empty teacher and students
There was a problem hiding this comment.
Actually this is needed to fix current classes, which have been affected already
virgilchiriac
approved these changes
Oct 5, 2023
virgilchiriac
pushed a commit
that referenced
this pull request
Oct 6, 2023
* handle empty, null and undefined lists * change scope of unique members assertion to fix current classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handles empty and undefined ldapDns for user search in ldap class sync.
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.