EW-619 DataPort review testing part #4442

MajedAlaitwniCap · 2023-09-27T08:08:57Z

Description

Review comments testing Part

Links to Tickets or other pull requests

Base links
EW-619

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
QA: In addition to review, the code has been manually tested (if manual testing is possible)
All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

…test.

…n test.

…e test.

…i-schul-cloud/schulcloud-server into EW-619-DP-review-testing-part

apps/server/src/modules/account/uc/account.uc.spec.ts

apps/server/src/modules/account/services/account.validation.service.spec.ts

apps/server/src/modules/account/services/account.service.spec.ts

apps/server/src/modules/account/services/account.service.integration.spec.ts

apps/server/src/modules/account/services/account-idm.service.spec.ts

apps/server/src/modules/account/services/account-idm.service.integration.spec.ts

apps/server/src/modules/account/services/account-db.service.spec.ts

apps/server/src/modules/account/mapper/account-entity-to-dto.mapper.spec.ts

apps/server/src/modules/account/repo/account.repo.integration.spec.ts

sonarqubecloud · 2023-10-06T10:12:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
29 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

This reverts commit a4364ec.

Metauriel and others added 22 commits July 14, 2023 12:37

review comments 14-07-23

01b8681

Delete auto generated test file.

40fb0c0

Use setup method and account factory in account entity to dto mapper …

8db2af2

…test.

Use setup method and factories in account response mapper test.

2a33de2

Use setup method and test structure in account idm to dto mapper tests.

c7d00f1

Use setup method and better test structure in account repo integratio…

8234ea3

…n test.

Use setup and new test structure in account api test (part 1).

4208bc2

Use setup and new test structure in account api test (part 2).

9e2126c

Add missing description for test case.

836b97c

update function and solve todo

f9ea21e

Use setup and new test structure in account db service test

31da828

new test structure account idm service integration test

a958007

use setup for account idm service integration test

edd618d

Use setup and new test structure in account.uc.spec.ts.

0575f0b

use setup for account idm service test

75fd0cc

Use setup method and new test structure for account.validation.servic…

c1bd6ca

…e test.

use setup and new test structure for account service integration test

b7b259a

Merge branch 'EW-619-DP-review-testing-part' of https://github.com/hp…

30faf5b

…i-schul-cloud/schulcloud-server into EW-619-DP-review-testing-part

Merge branch 'main' into EW-619-DP-review-testing-part

61c3d49

Use setup method and new test structure in account.service.spec.ts test.

870477f

Fix order in account.service.integration.spec.ts

e2e2eb3

Remove unnecessary tests and resolved todos.

0f2bbe0

MajedAlaitwniCap requested a review from WahlMartin September 27, 2023 08:09

MajedAlaitwniCap and others added 3 commits September 27, 2023 11:16

resolve security hotspot issue

64a875f

resolve security hotspot issue

d727557

Merge branch 'main' into EW-619-DP-review-testing-part

7a72638

MajedAlaitwniCap requested a review from Fshmit September 28, 2023 07:20

Fshmit changed the title ~~Ew 619 dp review testing part~~ EW-619 DataPort review testing part Sep 28, 2023

MajedAlaitwniCap enabled auto-merge (squash) September 28, 2023 07:22

MajedAlaitwniCap disabled auto-merge September 28, 2023 07:22