Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4375 - fix api generator #4435

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Sep 25, 2023

Description

api generator was confused somehow, and could not read correctly some types
this is a quick fix and a followup should clean it it

types-api-generator

Links to Tickets or other pull requests

BC-4375

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@virgilchiriac virgilchiriac enabled auto-merge (squash) September 25, 2023 07:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@virgilchiriac virgilchiriac merged commit b1c09d4 into main Sep 25, 2023
42 of 43 checks passed
@virgilchiriac virgilchiriac deleted the BC-4375-api-generator-browken branch September 25, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants