BC-4942 - authorization reference service

[CeEv]

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4942

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

• DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
• QA: In addition to review, the code has been manually tested (if manual testing is possible)
• All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

[SevenWaysDP]

authorization/domain/rules/*

authorization/domain/rules/* is ok
or
authorization/rules/*

I personally would not expect the rules to lie in the services

[dyedwiper]

I also wondered about the placement of the rules-folder. I was a bit surprised at first to find it in the service-folder and would have expected it one level up. But it shouldn't be outside of the domain-folder because the rules are part of the domain.

[CeEv]

I move the folder to domain/rules but after thinking about it, the really correct place are domain/uc. The rules are part of the domain. The domain include 2 layers with clear dependency order, the service and the uc. The rules are part of the UC and should unknown in service layer.
But in the context that they are placed in the wrong module, it is simpler to hold them on the place domain/rules.

Edit: interessting point is ..they should unknown in service layer. But the rules manager is places in service layer. It is interessting to think about it. :D

[dyedwiper]

Regarding the layer question: I see no contradiction to our concept. The service is exported by the module and can be used in other modules' UCs. That's just like the services in other modules.

Or in other words: The rules can be known by the service of the authorization module, but the authorization service (and thus the rules) shouldn't be known to other modules' services, but only to the UCs.

Questions should be resolve

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
42 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here