Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4375 - add list of students #4411

Merged
merged 12 commits into from
Sep 21, 2023
Merged

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Sep 15, 2023

add the list of students to submission items list
it was needed also to enhance board authorizable to contain names of users and also
to populate students and substitute teachers for course

Description

Links to Tickets or other pull requests

BC-4375
hpi-schul-cloud/nuxt-client#2794

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

add the list of students to submission items list
it was needed also to enhance board authorizable to
contain names of users and also
to populate students and substitute teachers for course
@virgilchiriac virgilchiriac added the WIP This feature branch is in progress, do not merge into master. label Sep 15, 2023
@virgilchiriac virgilchiriac self-assigned this Sep 15, 2023
@virgilchiriac
Copy link
Contributor Author

the old PR was dismissed and old branch renamed
for a comparison https://github.com/hpi-schul-cloud/schulcloud-server/compare/BC-4375-show-submission-status-bkp?expand=1

@virgilchiriac virgilchiriac removed the WIP This feature branch is in progress, do not merge into master. label Sep 18, 2023
return [];
}

private extractUserList(users: User[]): UsersList[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make static

@virgilchiriac virgilchiriac enabled auto-merge (squash) September 21, 2023 13:26
@virgilchiriac virgilchiriac merged commit 84c8f45 into main Sep 21, 2023
41 of 42 checks passed
@virgilchiriac virgilchiriac deleted the BC-4375-show-submission-status branch September 21, 2023 13:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants