Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4938 - Add school specific Terms of Use (Nutzungsordnung) for new school admin page #4399

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Sep 11, 2023

Description

QA note:
Change tested on env:
https://brb-bc-4938-add-school-specific-terms.cd.dbildungscloud.dev/
https://nbc-bc-4938-add-school-specific-terms.cd.dbildungscloud.dev/
https://default-bc-4938-add-school-specific-terms.cd.dbildungscloud.dev/
No issues found. All conditions are met. See JIRA ticket: https://ticketsystem.dbildungscloud.de/browse/BC-4938

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4938
hpi-schul-cloud/dof_app_deploy#635
hpi-schul-cloud/nuxt-client#2799
hpi-schul-cloud/schulcloud-client#3301

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas self-assigned this Sep 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@davwas davwas merged commit 718ccaf into main Sep 13, 2023
43 checks passed
@davwas davwas deleted the BC-4938-add-school-specific-terms branch September 13, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants