Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4100 - Create Demo School Endpoint #4365

Closed
wants to merge 75 commits into from
Closed

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Aug 29, 2023

Description

Implementation of an endpoint that

  • creates a demo-school with users, courses and lessons
  • can be used to run cypress end-to-end-tests
  • requires a specific permission to be enabled: "FEATURE_DEMO_SCHOOLS_ENABLED"
  • which is only granted to a specific cypress-user (at the moment)

The configuration of the school is always the same (at least in this first stage).
The password for all users is generated and returned as part of the response.
Email-adresses are extended by a postfix that is the same for the whole school.
All generated entitites are returned with their type and id.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4100
hpi-schul-cloud/nuxt-client#2827
hpi-schul-cloud/dof_app_deploy#651

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@uidp uidp added the WIP This feature branch is in progress, do not merge into master. label Aug 29, 2023
constructor(private readonly repo: DemoSchoolRepo) {}

async createSchool(): Promise<DemoSchool> {
const school = new DemoSchool({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a name with a DEMO_ prefix.
Because in case we want to find the demo schools later we have a easier time :)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Metauriel Metauriel closed this Jan 26, 2024
@hoeppner-dataport hoeppner-dataport deleted the BC-4100-create-demo-school branch June 3, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants