Revert "BC-5162 - drag and drop race condition (#4420)" (#4427)

This reverts commit 476f79c.

apps/server/src/modules/board/repo/board-node.repo.spec.ts

@@ -1,6 +1,6 @@
 import { EntityManager } from '@mikro-orm/mongodb';
 import { Test, TestingModule } from '@nestjs/testing';
-// import { ColumnBoardNode } from '@shared/domain';
+import { ColumnBoardNode } from '@shared/domain';
 import { MongoMemoryDatabaseModule } from '@shared/infra/database';
 import {
 	cardNodeFactory,
@@ -208,7 +208,7 @@ describe('BoardNodeRepo', () => {
 			});
 		});
 	});
-	/* BC-5162 - avoid race condition due to unit of work
+
 	describe('findById', () => {
 		describe('when boardNode exists in the database but NOT in the unit-of-work', () => {
 			it('should return an equal object', async () => {
@@ -236,5 +236,4 @@ describe('BoardNodeRepo', () => {
 			});
 		});
 	});
-	*/
 });

apps/server/src/modules/board/repo/board-node.repo.ts

@@ -7,7 +7,12 @@ export class BoardNodeRepo {
 	constructor(private readonly em: EntityManager) {}
 
 	async findById(id: EntityId): Promise<BoardNode> {
-		const entity = await this.em.findOneOrFail(BoardNode, id);
+		let entity = this.em.getUnitOfWork().getById<BoardNode>(BoardNode.name, id);
+		if (entity) {
+			return entity;
+		}
+
+		entity = await this.em.findOneOrFail(BoardNode, id);
 		return entity;
 	}