EW-784: Fix creation of accounts for users without account. (#4815)

apps/server/src/modules/user-import/mapper/import-user.mapper.ts

@@ -37,7 +37,7 @@ export class ImportUserMapper {
 			loginName: importUser.loginName || '',
 			firstName: importUser.firstName,
 			lastName: importUser.lastName,
-			roleNames: importUser.roleNames.map((role) => RoleNameMapper.mapToResponse(role)),
+			roleNames: importUser.roleNames?.map((role) => RoleNameMapper.mapToResponse(role)),
 			classNames: importUser.classNames,
 			flagged: importUser.flagged,
 		});

apps/server/src/modules/user-import/uc/user-import.uc.spec.ts

@@ -670,6 +670,45 @@ describe('[ImportUserModule]', () => {
 					});
 				});
 			});
+
+			describe('when the user does not have an account', () => {
+				const setup = () => {
+					const system = systemEntityFactory.buildWithId();
+					const schoolEntity = schoolEntityFactory.buildWithId();
+					const user = userFactory.buildWithId({
+						school: schoolEntity,
+					});
+					const school = legacySchoolDoFactory.build({
+						id: schoolEntity.id,
+						externalId: 'externalId',
+						officialSchoolNumber: 'officialSchoolNumber',
+						inUserMigration: true,
+						inMaintenanceSince: new Date(),
+						systems: [system.id],
+					});
+					const importUser = importUserFactory.buildWithId({
+						school: schoolEntity,
+						user,
+						matchedBy: MatchCreator.AUTO,
+						system,
+					});
+
+					userRepo.findById.mockResolvedValueOnce(user);
+					schoolService.getSchoolById.mockResolvedValueOnce(school);
+					importUserRepo.findImportUsers.mockResolvedValueOnce([[importUser], 1]);
+					accountService.findByUserId.mockResolvedValueOnce(null);
+
+					return { user };
+				};
+
+				it('should create it for the user', async () => {
+					const { user } = setup();
+
+					await uc.saveAllUsersMatches(user.id);
+
+					expect(accountService.save).toHaveBeenCalledWith(expect.objectContaining({ userId: user.id }));
+				});
+			});
 		});
 
 		describe('[startSchoolInUserMigration]', () => {

apps/server/src/modules/user-import/uc/user-import.uc.ts

@@ -361,7 +361,7 @@ export class UserImportUc {
 				username: user.email,
 			});
 
-			await this.accountService.saveWithValidation(newAccount);
+			await this.accountService.save(newAccount);
 
 			account = await this.accountService.findByUserIdOrFail(user.id);
 		}